html / CSS / JAVA

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • the theme switcher is not yet working - or it is not working for me
  • well done the calculations are working
  • limit the length of floating numbers, the display is extending to display more values try 2/3 = 0.6666666666666666

  Well done

  Marked as helpful

  0

  ---

  

  YksRocks•100

  @YksRocksPosted over 3 years ago

  @ChamuMutezva @lancemartija thanks bro for telling me I will fix this as fast as possible.🤗

  in the theme switcher, I set to change the theme by clicking on the theme number.try this if it does not work after that than ple suggest me😇

  0

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  @YksRocks, radio buttons will work perfectly for the theme switcher

  0

  

  YksRocks•100

  @YksRocksPosted over 3 years ago

  @ChamuMutezva thanks for suggesting😇

  0
• 

  Lance Martija•185

  @lancemartijaPosted over 3 years ago

  This is awesome!

  Great job. Though I have to point out something about the theme toggle buttons. It seems like it shows a small scroll bar right beside it. And I can't seem to view the calculator properly on mobile view. There's also a bug that outputs "undefined" when I click the equals sign without inputting any numbers and it even lets me add operators with it. Anyhow, it's pretty well done. Again, great job!

  One more thing, I suggest you use HTML5 landmarks so that your HTML code will be much more accessible and cleaner.

  Keep on coding!

  Marked as helpful

  0

  ---

  

  YksRocks•100

  @YksRocksPosted over 3 years ago

  @lancemartija thanks bro for telling me I will fix this as fast as possible.🤗

  can you tell what type of problem is happening on mob view?

  0

  

  Lance Martija•185

  @lancemartijaPosted over 3 years ago

  @YksRocks Your calculator is zoomed in quite a bit when in mobile view. It seems like your minimum media query is "480px." I suggest you make it "375px" because most mobile devices have that as their viewports.

  0

  

  YksRocks•100

  @YksRocksPosted over 3 years ago

  @lancemartija but I checked it till 280px width mob it is working are you using a browser other than chrome or brave??

  0

  

  Lance Martija•185

  @lancemartijaPosted over 3 years ago

  @YksRocks Oh sorry, I forgot to mention that I am using Firefox as my browser. My bad.

  0

  

  YksRocks•100

  @YksRocksPosted over 3 years ago

  @lancemartija I tried it with chrome, brave, and firefox but I don't know why it is not working only on fire fox☹☹. I will try to make it compatible with firefox also. Thanks for the review.

  0