HTML, CSS Grids

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Karishma, congratulations for your new solution!

  You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div tht takes all the content can be wraped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp

  Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Karishma•40

  @Kdt98Posted about 2 years ago

  @correlucas Hi Lucas, thanks for sharing feedback and helpful resources.

  0
• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Karishma,

  Congratulations 🎉 for completing this challenge, it was a great attempt. The web page looks good however, there are some issues I want to address.

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. Your CSS Grid looks great in the desktop version however the grid isn't responsive when adjusting the screen size. I noticed you took the desktop-first approach so a good suggestion would be to use the mobile-first approach as this will help you to change the layout for the cards, as you increase the screen size therefore your layout will be better in terms of responsiveness.
  3. You should set the background-color to your body tag instead of the .container as the body will cover everything.
  4. In your report, there was an issue regarding the link tag for your CSS fonts so I think you should double check if the URL is correct.

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  Marked as helpful

  0

  ---

  

  Karishma•40

  @Kdt98Posted about 2 years ago

  @romila2003 Hi Romila Thanks for sharing these points.

  1