HTML, Css, Grid-css, Flexbox-css

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Jesus,

  Well done, keep going :D

  I have checked, mainly your HTML structure, a few tips from me:

  • check your HTML issues report and try to fix it;
  • do you need this link media in the head?
  • this is a single page component so instead of section class="cards-container" I'd suggest to use the main tag;
  • I think these articles are unnecessary, I'd suggest to use just a divs => they are perfect for generic groupings of content;
  • in my opinion these span class="card-content__bg-image bg-supervisor" are unnecessary, I'd suggest to add these images inline in the HTML structure and use position absolute;
  • I'd recommend learning about BEM naming convention;
  • RWD: check a project in your browser by the inspector on different devices, for example iPone 4 => problem with margin, also tablets. Final conclusion: your project is not smoothly growing because you gave an explicit parameters. That's not a good practice especially that you want to use the flexbox or grid. It is essential to understand well the height and width vs min-height/max-height & min-width/max-width. You shouldn’t need to give items height unless they have a background or absolutely-positioned or floated elements within them that would not normally be accounted for in the height of an element. Experienced developers use min-height and min/max-width more than anything else. It allows elements to grow and shrink.

  Ps. Don't forget to upvote any comments on here that you find helpful.

  Greetings :D

  1
• 

  jhonna vhee gedalanga•10

  @jfontgdPosted almost 4 years ago

  I just learned coding. great work. keep it up :) Wish i could post mine soon here

  0