Design comparison
SolutionDesign
Solution retrospective
please leave your suggestion and critics it will be helpfull for me
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @Grishmita 👋🏻, it's me again 😅
Since I left some suggestions on your last post, I wanted to suggest my help with this one as well.
<section class="grid-container">...</section>
should be<main class="grid-container">...</main>
this will fix accessibility issues. Don't forget to generate a new report once issues fixed.- To fix HTML issues, just change backslash
\
in yourimg
tag<img src="images\icon-sedans.svg">
to forward slash/
such us this one<img src="images/icon-sedans.svg">
. Generally,img
tags must have analt=""
in tag, but in this case since the icon is for decorative purposes only, you can putaria-hidden="hidden"
to hide it from screen readers.
I hope this was helpful, I think you got a really good hang of CSS grids, keep going. Cheers 👾
Marked as helpful1 - @lordexgPosted about 3 years ago
Images must have alternate text.
<img src="source" alt="a describe for the img">if the image source has been deleted or something happens to it, the alt text will appear next to the image.
I am not an expert but I want to give some help 😄😄
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord