HTML, CSS (grid)

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, it looks really good! There are only 2 things that really needs fixing here:

  1. Your background: you could give the body a background-size: contain, that will fix the desktop view. In mobile view, do the same and also, I'd get rid of the background-position: center, there's no need for it ^^

  2. Take a look at the accessibility report as well and swap the appropriate divs to more semantic elements! Semantic markup is very important. Regarding your alt text, "Hero illustration" isn't a functional alt I'm afraid. :) I suggest reading this guide if you want to have a better understanding of this topic: (https://axesslab.com/alt-texts/)

  Marked as helpful

  1

  ---

  

  Jithu S Nair•30

  @jithusnairPosted about 3 years ago

  @FluffyKas Hey, thank you so much. The link on alt-text was really helpful.

  0
• 

  Haobijam Chetan Singh•195

  @chetanhaobijamPosted about 3 years ago

  Great solution. Just give some top margin/padding to the Heading (Order Summary) to match the design. Also try to fix the accessibility issues by using semantic HTML elements.

  0
• 

  Laslow•65

  @vasilykudlotyakPosted about 3 years ago

  Nice solution

  0