HTML/ CSS ( grid / flexbox/ @media ) a new proprieties

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 5 months ago

  @jonathanPons

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Use of semantic HTML elements

  Things you could improve ✍️

  • Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • By convention CSS classes are formatted like this container-main. It's not recommended to use capital letters in your classes.

  • Try to make your recipe more responsive, the padding at the top should disappear on smaller viewports.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0
• 

  geomydas•1,440

  @geomydasPosted 5 months ago

  Gotta get them googling skills. Use ::marker pseudoselector if you want to manipulate the bullet/numbering on lists. I don't reccomend using ::before for it, ChatGPT isn't always the best. You would use it like this

  li::marker {
  color: red}
  

  8 hours is a too much time for a newbie project like this but keep on making newbie projects and soon it will get faster.

  Marked as helpful

  0