HTML CSS (GRID FLEX 1%)

Community feedback

• 

  Edgar Burtnieks•465

  @edburtnieks-privatePosted over 4 years ago

  Hey Manish, solid solution and looks great!

  Having a quick look I noticed some small things that could be improved.

  First, I would rethink how you structured your heading element. In general, you want to avoid skipping heading tags. For example you have h4 after h2 in .item1. I think it would make more sense to use only h2 and h3 or even just h2. For Join our community, Monthly Subscription and Why Us leaving rest as p or small elements. You shouldn't choose heading elements based purely on their color and size. Most often yes, but not always.

  Another thing, you can try applying styles with "mobile first" approach, I think it would reduce your CSS a bit :) Continuing about responsiveness, you should extend breakpoint, because right now on smaller screen sizes, applying desktop styles, text inside two columns at bottom is really narrow.

  Other than that, nice work. Keep it up! :)

  1

  ---

  

  Manish Singh Rawat•10

  @TheDeveloper-Manish96Posted over 4 years ago

  @edburtnieks Thank you so much for your valuable feedback.I will definitely apply your suggestion in my next project. again thank you man.

  0