Design comparison
Solution retrospective
Another challenge done! This was my first Pro challenge. It looked very intimidating at first, but in the end, it wasn't bad at all.
I did struggle with positioning the hero images on the tablet and desktop views, however. Does anyone have any tips for cutting off the sides of your images without messing up your layout?
Thanks for looking!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hi there, Heather Smith! 👋
Congratulations on completing your first PRO challenge! 🎉 Good effort on this one! 👍
The layout for the hero section in this challenge can be a little tricky! You could try adding the images in the hero section as background images, but I don't know if that would make it difficult to keep those images in their place when the screen is resized. 😅
I believe I used CSS grid to layout the hero section in my solution to this challenge, and it worked out rather well, I think. The text content in the center of the hero section could take up a grid column with a fixed width, and the two images to the sides could fill up the remaining space. You might need to add
overflow: hidden
to the sections containing the images, though, in order to make sure that they are clipped when the size of the screen decreases. 😉Besides that, I think adding
cursor: pointer
to the buttons in your solution would be a nice touch! 😀Hope that is helpful. 🙂
Keep coding (and happy coding, too)! 😁
Marked as helpful3@sorengreyPosted over 3 years ago@ApplePieGiraffe Oh wow, hi! I definitely looked at your solution on Github for help while I was working on this. 😅 Yours is incredible! I love all the animations and cool things you added to it.
Thanks a bunch for the tips, especially about fixing that overflow. I will definitely try the images as a background. I was trying to avoid setting up a grid and columns, but I see what you mean. I might have to, lol.
Thanks again!
1@ApplePieGiraffePosted over 3 years ago@sorengrey
Haha, awesome! 👍 Glad to help! 😀
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord