Travolgi 🍕• 31,420
@denielden
Posted
Hello Jan, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
from.container
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
0
Jan• 90
@jandoyaoen1
Posted
@denielden thank you very much. I would definitely use these, especially the semantic html and the responsive css style code.
1
Travolgi 🍕• 31,420
@denielden
Posted
@jandoyaoen1 You are welcome and keep it up :)
0