HTML, CSS, Google Fonts

Community feedback

• 

  Lucas Estevam•210

  @tl-lucasestevamPosted over 3 years ago

  First congratulations! Your code is much cleaner now.

  But there are still some caveats, when starting a tag like h2 you cannot put a div inside it to make some of the text highlighted use the strong tag for example inside h2 instead of the div.

  <h2>
            Get
            <strong id="insights">insights</strong>
            that help your business grow.
  </h2>
  

  And also in the stats part you put a span wrapped around a div, this is not allowed in the HTML, do it that way:

  <div>
              <span class="number">10k+</span>
              <span class="word">companies</span>
  </div>
  

  So that you can better understand the concepts of div and span I got the definitions from w3schools.

  DIV:

  The <div> tag defines a division or a section in an HTML document.
  
  Note: By default, browsers always place a line break before and after the <div> element.
  

  SPAN:

  The <span> tag is an inline container used to mark up a **part of a text, or a part of a document**.
  
  The <span> tag is much like the <div> element, but <div> is a block-level element and <span> is an inline element.
  

  In other words, a div is used to represent a block of other HTML elements, whereas a span is used to mark part of the text/document. The other difference also the div is a block-level element that way it occupies all the space it can take up on the screen, this can be seen in dev tools when inspecting a div since the span is an inline element, it only takes up space the element within it needs.

  Link to a post that better explains this concept

  About the image to keep the same height without it being cut to the same proportion I don't know anyway. But you can put the media query to put the image on top when it starts to get too cropped by 900px / 800px.

  Whenever you send a project here to the mentor frontend it goes through an analysis to check for some errors, you can see this report by clicking on the "view report" button in the blue field below your project preview.

  Congratulations again! keep studying and practicing!

  Marked as helpful

  2