Design comparison
Solution retrospective
I did my 3rd challenge. If you have any suggestions for more improvement in this challenge , please let me know!. Also I have an issue , [ the "annual plan and $59.99/year" I tried to make it in same line as the "music icon" and "change" but it whatever I did, it is showing a little downwards. ] Got any suggestions?
Anyway another Question , I have is " Is writing an external css is industry standard or people more rely on intenal css?, I personally find external css preferable for me and much more organized but I have seen so many projects where people used internal or inline css. I understand that external css takes a little bit more time to execute than other two. What do you guys suggest? How can I learn the ways industry works? "
Thanks anyway!
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey! It looks good!...
to make the
annual plan and $59.99/year
in the same line withmusic icon
andchange
:.box2 { //... display: flex; /* center with flex */ align-items: center; } .music-icon { margin-right: 20px; /*margin-top: 10px; */ <--- Remove /* height: 50px; */ <--- Remove /* width: 50px; */ <--- Remove } .box3 { /* display: inline-block; */ <--- Remove /* margin:10px 0 0 10px ; */ <--- Remove }
and you need to change the
id
attribute toclass
because you style theimg
element with class but you used theid
attribute<img src="images/icon-music.svg" alt="music icon" id="music-icon">
<img src="images/icon-music.svg" class="music-icon" alt="music icon" >
- This
<p class="Change">Change</p>
, Should be an anchor link<a>
- These
<p class="payment">Proceed to Payment</p>
,<p class="cancel-order">Cancel Order</p>
Should be wrapped with<button>
...Buttons
are used for actions like opening or closing something, or sending a form.
I hope this is helpful to you... Keep coding👍
Marked as helpful0@FloraBloombluePosted over 2 years agohi just a question, so I was doing a challenge where there is an image in black and white and I have to use a color over it. so the image with black and white has shade of color on it. I saw the overlay method, linear gradient. Maybe I am doing it wrong, but the image tag in html is there. Now for overlaying I am using that image class, and there I wrote the attributes like linear gradient.... etc. or box shadow, or overlay, it is not working. No color is coming over the picture. Can you guys help me on it?
0 - This
- @Abdurehman420Posted over 2 years ago
hello !! nice work there bro
no external CSS is cool.in bigger projects you will be working with external CSS because writing everything in one single file makes it harder for others to understand
if you used display flex on the music icon and text container, then give the 59,99$ paragraph, justify-self:flex-start;
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord