Skip to content
Submitted over 2 years ago

HTML CSS GIT

Chicaofmp•30
@chicaofmp
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi!

After a long journey i had a courage to try another challenge. This one is harder than the last one because of the position and hover issues. Feel free to criticize and advice my coding. I am just learning, but i want to be a lot better. Lets all improve together!

Francisco "Chicaofmp" Moura

Community feedback

  • Marcos Porto Rafael•110
    @mrcsportoPosted over 2 years ago

    Awsome Chicão! Try to correct some accessibility issues and insert the Div into the landmarks and also take the element style out of the element body.

    1. <header>This is the header</header>
    2. <main>This is the main</main>
    3. <footer>This is the footer</footer>
    Marked as helpful
    0
    Chicaofmp•30
    @chicaofmpPosted over 2 years ago

    @mrcsporto hey,

    I will organize my html better.

    <header> <main> <footer>

    Thanks for the advice.

    1
  • Abdul•8,540
    @SamadeenPosted over 2 years ago

    Hey!! Cheers 🥂 on completing this challenge.. .

    Here are my suggestions..

    • You should nest your divs and paragraph in a main tag.
    • You can wrap your attribution section in a footer tag to avoid accessibility issues.

    This should fix most of your accessibility issues

    . Regardless you did amazing... hope you find this useful... Happy coding!!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord