html css

Community feedback

• 

  Ahmed Faisal•5,095

  @afrusselPosted about 3 years ago

  Good work. There is some width and height mismatch on the card. I would like to request you please take a look at my solution it may help you to find your issues

  Marked as helpful

  2

  ---

  

  Mohammed Rayan sailani•230

  @rayansailaniPosted about 3 years ago

  @afrussel Thanks for the reference, I will surely go through your solution. I don't have the pro version hence, I usually just eye ball these measurements, how do you come up with perfect measurements ?? (practice I guess xD) would love to know..

  0
• 

  Ayush Sharma•85

  @ayushsh841Posted about 3 years ago

  I would suggest using relative units when writing CSS so that they always adjust to the screen space like rem/%.

  Marked as helpful

  1

  ---

  

  Mohammed Rayan sailani•230

  @rayansailaniPosted about 3 years ago

  @ayushsh841 Thanks, I'm in process of learning that. I would surely implement it.

  0
• 

  Rohail Taha•355

  @rohailtahaPosted about 3 years ago

  Awesome work. I looked at the code. In your media query you used min-width:350px, I think you actually wanted max-width here because you would want body font size to be smaller(12px) in smaller screen sizes? If you use min-width in media query, then the styles applied will be for screen sizes greater than or equal to 350px. But I think you wanted those styles to be applied for screen sizes less than or equal to 350px? Am I wrong?

  Marked as helpful

  1

  ---

  

  Mohammed Rayan sailani•230

  @rayansailaniPosted about 3 years ago

  @Rohail77 That's a mistake from my side, I was wondering how it worked and now checked it that I was testing the website at 351px on dev tools. This is embarrassing, but now I won't forget xD.

  0