Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS, Flexbox

P
MrKB03-creatorβ€’ 90

@MrKB03-creator

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

dimar hanungβ€’ 560

@dimar-hanung

Posted

Hi.. πŸ‘‹, Congrats completing the challenge πŸŽ‰Β .

I have some interest and feedback with your code

That i like:

  1. I appreciate the similarity of your results with the design, a bit different scale but still good πŸ‘
  2. html is pretty good, not too nested and with combination semantic HTMLπŸ‘

My Feedback:

  • it’s good in normal laptop, but in 1920px it’s not center, because you set max-width:1440px , remove max-width or add margin: 0 auto (make it center harizontal) will fix it
  • You can seperate file by folder to be more structured, for example:
public/
β”œβ”€ images/
β”‚  β”œβ”€ qr-code-image.png
β”œβ”€ styles/
β”‚  β”œβ”€ main.css
β”œβ”€ favicon.png
index.html

overall is good, nice solution, hope it useful πŸ™Œ

Marked as helpful

0

P
MrKB03-creatorβ€’ 90

@MrKB03-creator

Posted

Hi.., Thank you so much for your help and feedback. It helped me to understand and organize my directory well and see the dimensions of the screens that I had not considered. Best regards @dimar-hanung

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord