dimar hanungβ’ 560
@dimar-hanung
Posted
Hi.. π, Congrats completing the challenge πΒ .
I have some interest and feedback with your code
That i like:
- I appreciate the similarity of your results with the design, a bit different scale but still good π
- html is pretty good, not too nested and with combination semantic HTMLπ
My Feedback:
- itβs good in normal laptop, but in 1920px itβs not center, because you set
max-width:1440px
, remove max-width or addmargin: 0 auto
(make it center harizontal) will fix it - You can seperate file by folder to be more structured, for example:
public/
ββ images/
β ββ qr-code-image.png
ββ styles/
β ββ main.css
ββ favicon.png
index.html
overall is good, nice solution, hope it useful π
Marked as helpful
0
P
MrKB03-creatorβ’ 90
@MrKB03-creator
Posted
Hi.., Thank you so much for your help and feedback. It helped me to understand and organize my directory well and see the dimensions of the screens that I had not considered. Best regards @dimar-hanung
0