HTML CSS FLEXBOX

Community feedback

• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi kudos2Shef

  Congrats on completing the challenge.

  I noticed that to center the card you've used properties like position : relative etc on your card, well to center something you don't need these but simply use a flex or grid on main

  
  main {
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: space-around;
  align-items: center;
  }
  

  add these to your solution and remove the position : relative and top : 120px from your card. Also I see you've used headings in the wrong way. The card title must he a h1 instead of an h3. Each page must have a single h1 heading for the title. Headings must be in order from h1 through h6. Same for the footer instead of h6 , I think semantically a p element should suffice as I don't think that is a heading.

  Hope it helps

  Marked as helpful

  0
• 

  Azel Alyne Tan•40

  @azelalynetanPosted over 1 year ago

  Good job! Nice work. My only suggestion is don't skip heading levels. For accessibility, it's recommended to use heading in a logical order. Keep it up.

  0
• 

  Stevo_Dev Repo•560

  @A-pixel-uxPosted over 1 year ago

  Bro nice work, There is no much comment on this you did a perfect job especially on the responsive part. I will just advice to keep on practicing, They normally say practice made perfect. Keep it up, Thumb ups for this once again.

  0