HTML | CSS (Flexbox) | Vanilla JS

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  Take look at the following things:

  1- There is alot of rum to improve the markup, writing semantic markup is all about chosing the right html elemen for the content contained within it. You use alot of div where there are much more semantic html elements.

  2- This is only my a suggestion, make the result section a two row layout because at the moment they are stacked next to each other thightly.

  Well done.

  Keep coding :=)

  0

  ---

  

  Pierpaolo Pascarella•140

  @Pierpaolo01Posted over 3 years ago

  @MojtabaMosavi

  Thanks mate, I will defintely include more semantic tags in my project I think in the moment they don't come to mind so I just place a div haha

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  The You win You loose text is not showing up the same place as the You Tied notification is. The you Win you Lose is showing up to the right of the game pieces and the Tied is showing up below the game pieces as it looks like they should

  0

  ---

  

  Pierpaolo Pascarella•140

  @Pierpaolo01Posted over 3 years ago

  @palgramming

  I'm not quite sure what you mean, on my end all the "you win/lose/draw" texts are showing up at the bottom point of the triangle like I intended them too. Maybe you've loded an older commit from the GH Repo?

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Pierpaolo01 I checked it again the win or loose is showing up to the right of the two circles not in the triangle like the tie does

  0