html css flexbox

Community feedback

• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great Work @mohamed! You added a theme switcher which is not on design. Pretty cool~ However, it would be better if you use CSS-grid rather than CSS-flex since Grid is more efficient for positioning elements horizontally and vertically. And you may add column-gap and row-gap when u use Grid. Now, when the screen goes down to 1200px, the cards have no horizontal margins. Hope it helps. Happy coding!

  0

  ---

  

  mohamed farid•580

  @FaridJuniorPosted almost 4 years ago

  @MasterDev333

  hi MasterDev thank you for your nice feedback, yes I think you are right about using the grid but until the time I made this, I wasn't so good at using grid so I preferred flex thank you.

  0