Design comparison
Solution retrospective
Hello everyone, This card is one of my first works that was built with HTML5 markup, CSS, Flexbox. Looking forward to receiving your feedback, also i would really appreciate any suggestion. Thank you, Anna ❤
Community feedback
- Account deleted
Hello! Just wanted to point out that your media query doesn't seem to work. The problem is with this code you commented out:
/* .cancel-href::before { ... } .cancel-href:hover::before { width: 100%; */ }
The curly bracket at the very bottom is not commented out, which prevents the media query code below it from working. You should either remove the commented code altogether, or close the comment out on that curly bracket.
Besides that, nice work!
Marked as helpful1@AnnaUlianovaPosted about 3 years ago@idiotic-enigma Hello, yeah, indeed, i was trying to test some additional feature and being in a hurry missed that curly bracket, thanks a lot for noticing and your feedback :)
0 - @FluffyKasPosted about 3 years ago
Hey, a good looking solution! I'd have two suggestions though!
-
Your background: it needs a
background-size: contain
to cover the whole screen. Problem is, you used an additional (and unnecessary) container div to center your component, and that's where your height is (which you could change tomin-height
) which is needed for your background image to work well. So you either apply the background image on that container div, or move all the styling to yourbody
. The latter will result in less code, so I'd suggest doing that, but it's up to you of course. -
Your payment button uses the browser's default font-family, don't forget to change it! ^^
Again, congrats on completing your first challenge, really good job ^^
Marked as helpful0@AnnaUlianovaPosted about 3 years ago@FluffyKas thank you, i found your suggestions very helpful, my work looks complete now ^^
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord