HTML, CSS, FLEXBOX , MOBILE FIRST, GIT, BEM

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello JuniorQuin, Congratulations on completing this challenge!

  You’ve done really good work here putting everything together, I’ve some suggestions to improve the design:

  You need to fix the container size that is a bit off, this challenge uses the standard container size that is max-width: 1110px.

  To make the image have a better fit inside of it, make the component image responsive with display: block and max-width: 100% (this makes the image fit the column/div size) and respect the component size while it scales down. To make it crop while scaling use object-fit: cover.

  img {
      display: block;
      object-fit: cover;
      max-width: 100%;
  }
  

  The way you’ve applied the purple color is fine, but if you want the exact color tone of color of the challenge designs, you need to use mix-blend-mode to make the color blend between the image and the background-color of the container. See the steps below to apply to the img or picture selector:

  img {
  mix-blend-mode: multiply;
  opacity: 75%;}
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Juniorquin, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • use h1 element for the title and not a div. You can use span tag with class to change color of word
  • use p element for the text and not a div
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px or % use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  0
• 

  Patrick•800

  @PPechmannPosted about 2 years ago

  Hola Junior!

  Very well done on your first challenge here on FrontendMentor, good job!

  Regarding the BEM Methodology: You did apply it correctly, although the class names can get a bit confusing, as they seem too long.Try to keep it as short as possible. For example: Instead of .card-componente__descripcion__estadistica and .card-componente__descripcion__resumen, use: card__estadistica and card__resumen. Basically, you should use something__block, for standalone elements and something__block--modifier, for modifiers such as buttons with different stylings, for example. Here you will find a very in detail guide.

  The image: It is already very well positioned, I would only leave it at background-position: center, instead of center top.

  Further adjustments: I would also recomment giving the card-componente__descripcion some padding and lower the font-size, to get it closer to the initial design.

  I hope my quick feedback is helpful and look forward to more of your solutions!

  Happy Coding :)

  Patrick

  Marked as helpful

  0