Design comparison
Solution retrospective
Hello Solution providers,
Here's my solution for the four-card challenge but I believe improvements can still be made.
I'll appreciate getting honest feedback also, ways on how I can achieve the card display without using flex-box or grid.
Thanks.
Community feedback
- @GerbenDolPosted over 4 years ago
I think your choice for using flexbox here was great. I don't see a reason to look for a solution that doesn't use either flexbox or grid. Care to let us know why you'd want that? 🙈
Your code is looking really clean and readable. CSS looks nice and DRY to me. Honestly, I think you did really good! Just for readability purposes try and keep your indenting in your CSS nice and consistent, as there's a few lines that are out of pace with the rest of your code. 👌
Hope to see more of your solutions soon! 😁
1@mrohizzyPosted over 4 years ago@GerbenDol The reason I asked for an alternative is to understand how it can be done using Relative and Absolute positioning which I tried using but was too tasking and I settled for Flex display instead.
I'll try to put in more effort in my indenting and making my codes more readable.
Thanks so much for your time and feedback.
0@mattstuddertPosted over 4 years ago@mrohizzy I would say using either Flexbox or Grid is pretty much always preferable to using
position
. Especially when it comes to usingposition: absolute;
as you're then essentially sticking the elements in place which will cause issues when you try to make it responsive.As Gerben said, you've done a really good job here! 👍
2@mrohizzyPosted over 4 years ago@mattstuddert @GerbenDol A big thanks to you both. This means a lot to me having my first ever challenge reviewed by you.
Thanks once more.
2@mattstuddertPosted over 4 years ago@mrohizzy you're welcome! Keep up the great work! 🙂
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord