Design comparison
Solution retrospective
Any feedback or suggestions for code improvements welcome!
Community feedback
- @mattstuddertPosted almost 5 years ago
Hey Steven, great work on this challenge! My only recommendation would be to add a
h1
as the main heading as opposed to ah2
. Every page you create should have a singleh1
as this is then used as the main page title for screen reader users.Keep up the great work!
0@stevenCsaundersPosted almost 5 years ago@mattstuddert 👌.
I have one additional question about using the section tag. Should you only use the <section> tag when you have a heading for the content in the tag? Is a div a better way to go if there isn't an h1-6 element?
0@mattstuddertPosted almost 5 years ago@stevenCsaunders hey Steven, yeah you should typically have a heading inside a
section
. So using adiv
instead would be fine. Sections are used for a larger grouping of themed content i.e. testimonial section or features/benefits section. So they're typically used for larger groupings of content which would normally include a heading.I hope that helps. Let me know if you have any other questions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord