html, css, flexbox

Community feedback

• 

  Jahrette Richards•80

  @SKLymerPosted over 3 years ago

  Hey Nguyen good job on the challenge.

  Your screen doesn't include the entire viewport when a user rotates their phone. I had the same problem when I did this problem initially. If you used 100vh on a container.

  It might be best to find another solution. Otherwise good job.

  Marked as helpful

  1

  ---

  

  Nguyen Duy•245

  @koalalikecodePosted over 3 years ago

  @SKLymer thank you for your suggestions, I will find a solution to this problem.

  0
• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  Nice work. So close to design. Great 👍

  Marked as helpful

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Congratulations on completing your first challenge. Great work .

  • Your first heading should be an h1 - use css for font size
  • headings should ascend in order , h1, h2, h3 etc . Do not skip headings.
  • since you have identified the elements below as buttons , they need to be buttons but i would also suggest to use a elements - it seems they are links to other pages. Always use the right elements where ever possible.

  <div class="user-confirm">
        <p class="agree-button">Proceed to Payment</p> 
        <p class="reject-button">Cancel Order</p>
      </div>
  

  1

  ---

  

  Nguyen Duy•245

  @koalalikecodePosted over 3 years ago

  @ChamuMutezva thank you for your advice, I will change my code

  0