Design comparison
Community feedback
- @mattstuddertPosted about 5 years ago
Great work on this challenge Lukasz, it looks awesome! One small pointer for the circle in the navigation. Instead of adding an extra
li
with a HTML entity inside, you could instead use a pseudo-element, like::before
and styling it like a circle. This would mean that you're not adding extra HTML.Keep up the great work! 👍
0@devluke88Posted about 5 years agoThank you for your feedback! I have also found other issue. When you resize to mobile and open the hamburger you can see menu appears but when you resize window back do desktop version, menu disappears.
Is it because display property was override by js script for the same property?
0@mattstuddertPosted about 5 years ago@devluke88 yeah, that's exactly it. Toggling
display
with JS will do it by adding an inline style, which out-specifies addingdisplay: block;
in your CSS.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord