Design comparison
Solution retrospective
-
Alright, my first attempt to adding JavaScript. It's not entirely there yet, but I wanted to show what I've done thus far, to learn from the feedback.
-
I'm also wondering how to change the input color of the input field once content is added. It now by default goes white, but I want it to keep the requested color. Which pseudo-class should I use?
Community feedback
- @AjdevisePosted almost 4 years ago
Try this selector to change color when content is added .form-input:not(:placeholder-shown).
1@katrien-sPosted almost 4 years ago@Ajdevise Oh, I'll be looking into that. Thanks :)
0 - @ApplePieGiraffePosted almost 4 years ago
Hey there, Katrien S! 👋
Nice to see you complete another challenge! 😀 Well done on this one! 👍 Overall, your solution looks great and responds well.
I suggest,
- Adding a
max-width
to the content of the page to prevent the left/right parts of the design from having too much space in between each other on extra-large screens. - Allowing the company logos to wrap onto a new line when the screen width becomes extra small (below 450px) to prevent the rest of the content from looking a little squeezed, then.
BTW, another pair of pseudo-classes you might be interested in looking into are the
:valid
and:invalid
pseudo-classes, which correspond with valid and invalid input being entered into an input field, respectively. You can combine them with the:focus
pseudo-class to apply styles to the input element only when it is focused and the input inside it is valid, for example. 😉Keep coding (and happy coding, too)! 😁
0@katrien-sPosted almost 4 years ago@ApplePieGiraffe Thanks! 😁 I am going to update the JavaScript-part this week and apply your suggestions. The
max-width
I knew. The pseudo-classes, I'd seen them pop up, but they're not in my daily vocabulary yet. Will change that. 😉0 - Adding a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord