HTML, CSS, Flexbox, Grid

Community feedback

• 

  Tomi•565

  @Tomi-pterPosted almost 3 years ago

  Really nice solution. Some suggestions:

  1. I noticed your media query condition starts at 1270px. Maybe between 850px and 1269px you could make it into a 2 column design as there's a lot of real estate being unused and make it into something of a tablet layout.
  2. In your grid-template-rows styling on .main you forgot to add a comma in the repeat function.

  Hope this helps 👍🏾

  0

  ---

  

  Iuliia Konovalova•260

  @IuliiaKonovalovaPosted almost 3 years ago

  @Tomi-pter Hi Tomi, thanks for looking into my code and for the feedback. You have a really good eye! About media query and the design, I simply wanted to preserve spacing and stick to the design that had been required

  0