HTML, CSS, Flexbox and Grid

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Hey Lukasz, just a heads up that there seems to be an issue with your preview version. It's showing the original starter code with no HTML structure or CSS.

  0

  ---

  

  Lukasz•315

  @devluke88Posted about 5 years ago

  @mattstuddert done!Thanks for your feedback 👍

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @devluke88 good stuff. It looks great! Your HTML structure is really good and your solution matches up to the design nicely. Here are a couple of really small pointers after taking a look at your code:

  • In your alt text you're currently hyphenating the text e.g. illustration-intro. This text will be picked up by screen reader software to help describe the image. So I'd recommend writing a description in the usual format you'd write a sentence, as opposed to joining the words up with hyphens so that it makes sense to screen reader users.
  • You could use the blockquote element as opposed to a div for each of the testimonials, which would add more meaning to the HTML structure.

  I hope you find these tips useful! Keep up the great work 👍

  0

  

  Lukasz•315

  @devluke88Posted about 5 years ago

  @mattstuddert Sorry Matt, it should be working now ;-)

  0