Skip to content
Submitted about 2 years ago

Html Css Flexbox

Enrica•170
@ErriGarcia
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi all! This is my second challenge, please comment below if you have any suggestion. Thank you in advance

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi @ErriGarcia, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    1.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but all sizes as well.

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Enrica•170
    @ErriGarciaPosted about 2 years ago

    Hi @correlucas! Thank you so much for your advices. Great suggestions I will take notes and I'll take a look into your solution. Thank you so much for helping me!

    0
  • Adeola Ganiu•1,320
    @DeolabestPosted about 2 years ago

    Hi @ErriGarcia, great job!

    Here is my feedback:

    1. Try to reduce the size of your description to match the challenge requirement.

    Try:
    .qr-code-description { color: hsl(220, 15%, 55%); font-size: 14px; font-weight: 400; }

    Keep doing a good job!

    0
    Enrica•170
    @ErriGarciaPosted about 2 years ago

    @Deolabest Thank you so much!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord