HTML | CSS | Flexbox

Community feedback

• 

  P

  Øystein Håberg•10,410

  @Islandstone89Posted 10 months ago

  HTML:

  • The icons are decorative, so the alt text should be empty:alt="".

  • "Learn More" would navigate to another page, hence it is not a button but a link.

  • Footer text must be wrapped in a <p>.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • You have written min-height: 100svh twice.

  • Again, only declare max-width on the card once. Also, it should be in rem.

  • Media queries should be in rem, not px.It is common practice to do mobile styles as the edfault, and use media queries for larger screens.

  0