Design comparison
Solution retrospective
Feedback always welcome!
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hey, Coty B! 👋
Nice job on this challenge! 🙌 It's a rather simple challenge but your solution looks good and so does your code! 👍
The only tiny thing I might suggest is to consider using a single
<h1>
tag per page (as that's commonly recommended best practice, at the moment) rather than more than one. In this case, some less-important heading tags (such as<h2>
or<h3>
) might work better for the headings in the card component. 😉And also, you could decrease the margin above the card component just a bit in the desktop layout so that the card doesn't get pushed too far down and look off-centered on desktop screens with smaller heights. But that's a very small thing, as well!
Keep coding (and happy coding, too)! 😀
0@cotybroPosted over 3 years ago@ApplePieGiraffe Hello ApplePieGiraffe, Thank you for the feedback! I didn’t realize I repeated the h1 tags until you brought that to my attention I’ll fix that.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord