Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @dumpdope1, Congratulations on completing this challenge!
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use
<picture>instead of<img>wrapped in a div. You can manage both images inside the<picture>tag and use the html to code to set when the images should change setting the devicemax-widthdepending of the device (phone / computer) Here’s a guide about how to usepicture:https://www.w3schools.com/tags/tag_picture.asp✌️ I hope this helps you and happy coding!
Marked as helpful0@dumpdope1Posted about 2 years ago@correlucas This help a lot thank you so much for this one.
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Rudolf Luayon, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
Prefer to use
removerpxto have your page working better across browsers and resizing the elements properlyThe rest is great!!
Hope it helps...👍
Marked as helpful0@dumpdope1Posted about 2 years ago@AdrianoEscarabote Thank you so much for this I will keep this one on mind :)
1 - @VCaramesPosted about 2 years ago
Hey @dumpdope1, great job on this project!
To make it easier to deal with CSS and have more control over your content, I suggest taking a look at CSS Resets.
It makes it easier to make changes and will ensure that everything will look the same regardless of browser used and don’t have to worry that the browser will be using its own styling.
One important thing about CSS Resets, is that there is no such thing as “one is better than the other.”
CSS Resets are customizable for your preference.
Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord