html, css, flex

Community feedback

• 

  P

  Alexander Lippitsch•120

  @LipAlex1Posted over 2 years ago

  Hi Jakub,

  nice work with plain HTML and CSS!

  You may want to look at the report as there are two ally issues. That is, because you aren't using a h1 tag. That is necessary for SEO reasons, though. Also you should use semantic HTML (header, nav, main, article, section, aside, footer).

  The mouse arrow turning into a pointer on :hover state is good but the color change of the button element is an :active state element effect.

  Also, if you hover over the buttons you can see that the card design flickers - i.e. hovering pushes the above elements further up. That is because your nth-child:hover pseudo selector adds a 1.5px border to the button element that is not there in regular state.

  Since there is a media query and a meta viewport rule I believe you want the design to be responsive. For that drop px values and use rem instead together with max-width rules on the CSS. Also, look into the box-sizing: border-box property-value-pair and what why it is favorable.

  I finished the same project earlier this week. Feel free to take a look at it.

  Keep up the good work and happy coding!

  All the best,

  Alex

  0

  ---

  

  JakubStranianek•300

  @JakubStranianekPosted over 2 years ago

  @LipAlex1 Thank you so much for your report :)

  I will try to avoid my mistakes and learn something new what did you write.

  Also i will look for your projects and write short review too.

  Wish you luck, keep push :)

  Jacob

  0