HTML + CSS first ever challenge

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Awesome work on this challenge, Roy! Nitya has already given some great advice. If you're looking for some good Flexbox and Grid tutorials here are a couple of great (and free) ones by Wes Bos:

  • flexbox.io
  • cssgrid.io

  1
• 

  P

  Nitya Gulati•665

  @nityagulatiPosted almost 5 years ago

  Hi Roy, the website looks great on desktop and tablets, nice work. Next steps would be to add CSS media queries and make the site responsive for mobile design.

  Also try working with Flexbox or Grid to create the layout instead of using absolute position, that will make switching the layout for mobile design easier.

  Another thing to consider, some of your class names are quite generic .div1, .div2 etc. Although perfectly fine for this project, it's a good practice to use more intuitive and meaningful names for your elements. You can look up CSS naming conventions for tips and ideas. How to name CSS classes

  Keep up the good work!

  1

  ---

  

  Roybrussel•35

  @RoybrusselPosted almost 5 years ago

  @nityagulati Thank you for taking your time to review my solution! Really appreciate the feedback and I will have a read about Flexbox and Grid, didn’t know about this yet.

  1
• 

  Matheus Sabino•15

  @mathesouzaPosted almost 5 years ago

  Nice

  1

  ---

  

  Roybrussel•35

  @RoybrusselPosted almost 5 years ago

  @mathesouza Thank you!

  0