HTML, CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<article class="Text"> with the main tag, and <div class="attribution"> with the footer tag to fix the accessibility issue. click here for more on web-accessibility and semantic html

  The image is not visible, to make it vissble use <img src=./images/image-qr-code.png" alt=""> instead of <img src="/Challenge/Newbie/qr-code-component-main/images/image-qr-code.png" alt=""> and give the alt attribute a value, its value is the description of the image.

  To center .Text on the page using grid, add min-height: 100vh to the body.

  Give .Text a width value and increase the padding value. e,g: width: 20rem which is 320px and padding: 1rem.

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  ZMB•720

  @ZMBAIGPosted almost 2 years ago

  Hi, It seems your solution is incomplete and I think you forgot to give a proper codes and therefore we are observing only the text that was provided in the challenge.

  There is no image and the grid layout or flexbox are not defined. Because in body css only 'Display: Grid' was mentioned. For Grid you can take help Here. I hope it will help you to complete a challenge.

  Marked as helpful

  0