HTML, CSS

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @ajasmine94

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage. You can try centering your card for example.

  • To learn more about centering elements I recommend reading this guide.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Try using semantic HTML elements like main, section and article.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • Be careful with setting a fixed width and height on your elements. If the content in these elements grows beyond these restrictions you’ll run into overflow issues. Keeping the height at auto - which block elements are by default - will be fine in most cases.

  • You don’t need to put width: 100% on block elements, they already take up the full width of their parents by default.

  • Try styling your elements using classes instead of ID’s. Most of the time they are the better choice. ID’s are mostly used to select elements using JavaScript, navigation on the page itself and to style unique elements.

  • I suggest leaving the width of your body as auto which it is by default. So to achieve this you can remove the fixed width.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  1

  ---

  

  Jas•140

  @ajasmine94Posted about 1 month ago

  @DylandeBruijn Hi Dylan, after learning about flexbox I have updated my solutions. It took a while but I wanted to thank you so much for the time and effort of providing this detailed feedback!! it helped greatly :)

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 4 months ago

  Hey there! 🙋🏽‍♂️

  Congrats on completing the challenge! ✅

  Your project looks fantastic!

  Here's a tip to make it even better:

  Using margin and/or padding isn't always the best way to center an element. Try this method to center an element vertically and horizontally:

  📌 Apply this CSS to the body (skip position or margins to make it work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  Hope this helps!

  Keep up the great work!

  Marked as helpful

  0