HTML CSS

Community feedback

• 

  Marlon Passos•940

  @MarlonPassos-gitPosted about 3 years ago

  good job, it was very similar to the original version, but everything can improve more

  • Your page could have broken down to 2 columns earlier, so this is kind of weird, see https://prnt.sc/1stmr0u

  • Each of the cards is actually a link to another area of the site, so in this case it would be nice if they were inside an <a> tag and that there was an effect when the muse passes over it

  • The <div class="header"> should be inside a <header> tag and only the cards inside the <main> tag

  • In this case the images of the cards are there more for decoration, in this case it is not necessary to give a description in the alt, it could just be an alt=""

  • Increase the size of the H2 a little

  • Decrease the shadow of the cards a little, it looks very strong

  • Images should have explicit width and height, see https://web.dev/optimize-cls/?utm_source=lighthouse&utm_medium=devtools#images-without-dimensions

  Marked as helpful

  1

  ---

  

  Prajwal Gautam•190

  @prajwal18Posted about 3 years ago

  @MarlonPassos-git I have noted it down, i'll implement it on the next iteration

  0