Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Html, Css, Desktop first

@Sahil-Yadav

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


If anything is wrong fell free to give an advice.

Community feedback

@woodbrettm

Posted

Looks great :)

Two tips =>

Tip One:

          <p class="why-us">
            Tutorials by industry experts <br />
            Peer & expert code review <br />
            Coding exercises <br />
            Access to our GitHub repos <br />
            Community forum <br />
            Flashcard decks <br />
            New videos every week
          </p>

Instead of using a <p> tag here with breaks, a more screen-reader friendly way would be to use an unordered list, like so =>

<ul class="why-us>
    <li>Tutorials by industry experts</li>
    <li>Peer & expert code review</li>
    <li>Coding exercises</li>
    <li>Access to our GitHub repos</li>
    <li>Community forum</li>
    <li>Flashcard decks</li>
    <li>New videos every week</li>
</ul>

Tip Two:

<div class="sign-up-button">Sign Up</div>

Can't be focused by a keyboard. A more accessible way could be using the anchor tag.

<a role="button" href="">Sign Up</a>

You can then give it an a:focus-visible { } pseudo class for people using the tab key through a website.

Cheers :)

0

@Sahil-Yadav

Posted

Thanks a lot! I will keep that in mind :)

0

@woodbrettm

Posted

Ah to follow up, looks like role="button" would be incorrect in this case. role="button" indicates to screen readers that the element should have all functionality of a button including JS features that wouldn't be relevant. So would be better I think to have a class of btn or something on the anchor rather than assigning the button role.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord