HTML, CSS, CSS Variables and Flexbox and Javascript

Community feedback

• 

  Elroy Toscano•630

  @elroytoscanoPosted almost 3 years ago

  Hi David, you've done a great with this project. I went through your code, the HTML is well written, from accessibility to HTML semantics.

  After the breakpoint of 768px, the view changes from mobile to desktop, a scrollbar is visible. I checked through your code and in section "hero bg-dark", in the "::after" pseudo selector, you need to do "width:auto" or even removing "width:100%" would solve the issue. Secondly, in the mobile version, when you click on the "hamburger menu" open the sidebar and hover over the links, the color of the text becomes indistinguishable from the background. You could resolve that by changing the color to a lighter shade of the bg for appropriate text legibility. Finally, for the footer, when you hover over the links you may change the color of the links for visual feedback.

  Hope this helps.

  Marked as helpful

  0
• 

  P

  David Turner•4,150

  @brodiewebdtPosted almost 3 years ago

  Thanks for looking at this. I will go through it and fix the problems.

  1