@its-rkravi
Posted
Congratulations @SaumyaG1318 for completing the challenge.
Welcome to the Frontend Mentor Platform. I want to give you some feedback regarding your code. Inside the style.css file you write a lot of CSS properties. your code looks massy When I saw your code. you write a lot of properties which are not applied but you write it I don't know why.
Look at this code.
.circle {
/* Circle ki pershani */
position: relative;
left: 50%;
translate: -50%;
padding: 10px;
margin: 0;
height: 100%;
background-image: linear-gradient(#4d22ca, #4734f0);
border-radius: 50%;
max-width: 30%;
/* text ki pershani */
font-size: 1em;
color: var(--LightGray);
text-align: center;
text-justify: center;
}
there are a lot of problems in your code. So I just want to tell you go to this link link and watch How I write the code for same code. I think it helps you.
I just want to tell you our task is not to just make a web component. (aur kam khatam). Actually , Our task is also write the clean code so when someone watch our code he/she can understand easily. and in future if we need to do some changes. We can also do this without any problem.
I hope you understand what I want to tell you.
Few Tip:
Use more modern and flexible techniques like Flexbox or Grid for layout purposes. These CSS features are designed to make web development easier, more maintainable, and responsive across various devices.
I hope you find this feedback helpful.
Keep up the excellent work, and if you have any further questions or need assistance with anything, feel free to ask.
Mail : [email protected]
Instagram : its_rkravi
Together, we can continue to build a supportive and knowledgeable community.
Best regards, Rahul Kumar Ravi
Happy Coding!
Marked as helpful
@SaumyaG1318
Posted
@its-rkravi Thank you for taking the time to review my code Rahul. I honestly forgot about the optimizing the code and its looks, I am new to development and its been only a week and to be honest I was facing a lot of problems as I was doing this challenge and was learning almost everything while I was doing it. So the challenges kind of piled up and at the end I was just so happy to finish and upload my solution which too wasn't so easy for me. Me writing redundant code was me trying to get the circle done with trial and error. I am still learning, I will do better next time and learn more CSS techniques and I hope I too soon start writing clean code just like you.
