Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hi @Ashitaaka, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:
1.Prefer
class
instead ofid
to give style to your elements, choosingid
its not a good idea because it’s a too specific selector and it's better to use it forforms
or Javascript code.It is not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again.2.Use
<main>
instead of a simple<div>
this way you improve the semantic and accessibility showing which is the main block of content in this page. Remember that every page should have a<main>
block and that<div>
doesn't have any semantic meaning.3.For future projects, think about using relative units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices.✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord