HTML, CSS, BEM and JS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your “ images/illustrations” to fully remove them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

  More Info:📚

  MDN <input type="radio">

  MDN <fieldset>: The Field Set element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Elio Flores•400

  @eliofloPosted almost 2 years ago

  @vcarames Thanks for your feedback.

  When I started doing the challenge I realized that using a radio button would resolve to choose just one, but I didn't know how to insert text inside the radio button. That's why I used div. 😅️

  I take these suggestions and I'll update my project. 👍️

  0

  

  Elio Flores•400

  @eliofloPosted almost 2 years ago

  @vcarames I already updated my solution. Any feedback is welcome. Thanks.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @elioflo

  Nice! The form should only wrap the rating buttons themselves ( sorry, I should of made that clear)

  You also want to to have a legend after the form and before the first button that will be visually hidden.

  Marked as helpful

  1

  

  Elio Flores•400

  @eliofloPosted almost 2 years ago

  @vcarames Thanks for your comments that help me so much.

  Updated my solution.

  Add legend and use form just for the fieldset. Some new things I learned:

  • It's the 'has' pseudo-class CSS selector. Never used it before.
  • Use the 'submit' form event instead of the 'click' button event.

  Any feedback is welcome.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @elioflo

  Looks good!

  Keep it up!

  0