HTML CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Prajwal Gautam!

  I have some feedback on this solution:

  • For best practices, I recommend to set your tab size to 2, that way your code is more easy to read. It's also a common practice.
  • The alt value for the logo should be the company name Huddle.
  • For any decorative image, you should leave the alt="" and add aria-hidden="true" to make screen reader ignore the image. In this case the illustration image is just decorative image.
  • The aria-label for the link do not need Go to, just the social media platform. Screen reader will pronounce it as a link as long you are using the a tag.
  • Use rem or sometimes em instead of px. Using px won't allow the users to scale the size based on their needs.

  That's it! Hopefully this is helpful!

  0

  ---

  

  Prajwal Gautam•190

  @prajwal18Posted about 3 years ago

  @vanzasetia i like the tab size to be 4 maybe i will change it to 2 in the future, apart from that everything else i will implement it. Thanks for the feedback

  0