Design comparison
Solution retrospective
your feedback, Please
Community feedback
- @palgrammingPosted over 3 years ago
Should not be able to type letters into the bill and number of people inputs
Marked as helpful2 - @Tyson-WellingsPosted over 3 years ago
Well done completing the challenge! I just submitted my solution for the same challenge myself. Unfortunately on my screen I notice a few errors in the functionality.
The tip buttons don't stay highlighted when another input is clicked. Ideally they should stay highlighted to give the user visual feedback. Otherwise you wouldn't know what tip percent you decided on. Also I have clicked around and filled the inputs in different orders. I have yet to be able to get the tip calculator to actually spit out a result. The error messages are not working either so I can currently input 0 and negative numbers without any error messages popping up.
The reset buttons works! Visually you've managed to recreate the layout and it is responsive! Overall is seems like the JS needs a little more testing while the html and css are ready to go.
Marked as helpful1@Ezzaldin97Posted over 3 years ago@Tyson-Wellings try to press enter button after entering the number of people
It works
0@Tyson-WellingsPosted over 3 years ago@Ezzaldin97 Your right it did work! I have edited my previous comment with more feedback after playing with your calculator more let me know if you have any questions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord