HTML, CSS & SASS

Community feedback

• 

  Yashasvi Singh•235

  @Yashasvi2704Posted over 3 years ago

  Hi Bishal,

  Great work. Just around the media query( around 800px-900px), the text is really squished up and there is no white space between the heading, paragraph and the statistics. That section needs some rework.

  One suggestion, instead just of making the whole content section responsive, you can also make the image responsive and divide the width wisely.

  1

  ---

  

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  @Yashasvi2704 thanks for the suggestion... what i did was make the height of the image fixed so that it fits the card component... but if i make it responsive from the width... it shrinks the image and the background color of violet shows up... any syggestions on how to fix this?

  0
• 

  noble mutoko•40

  @codeplayer12Posted over 3 years ago

  Nice work. checked the site, found the width in tablet mode the width goes to the edges of the screen and leaves whitespace at the bottom.

  0

  ---

  

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  @codeplayer12 i see... any suggestions you would like to make??? i will edit the code... it seems fine in a PC and in a mobile but i doubted about the tablets...

  0

  

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  @codeplayer12 can you please give me the resolution of the tablet which you have used to visit this website... because in the Developer mode... it seems fine to see in all the provided options

  0

  

  noble mutoko•40

  @codeplayer12Posted over 3 years ago

  @bishalmallick the resolution i tested for the tablet was 800*1280. Checked the code and figured the background-color is on the main-section and not the body. So there is space between the two where there is no color

  0

  

  Bishal Mallick•115

  @bishalmallickPosted over 3 years ago

  @codeplayer12 is this happening due to the fixed height & width of the main-content section... and about the background-color... the container contains all the elements and the main section is the whole card component and has the background-color of light blue... and i didnt understood your last sentence... if you dont mind... can you please elaborate???

  0

  

  noble mutoko•40

  @codeplayer12Posted over 3 years ago

  @bishalmallick so the body is the parent to the main content area. if you put the background color on the body the height for the main container will not be an issue

  0