HTML, CSS and Media queries

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @Anthonia03!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Keyamo Oghenerukevwe Anthonia•20

  @Anthonia03Posted 9 months ago

  @danielmrz-dev It does, thank you.

  1
• 

  Iamtrieves•210

  @IamtrievesPosted 8 months ago

  I am out here stuck on uploading a god damn solution. I got everything right but its always telling me that the url provided should be a github, or blah blah blah

  0

  ---

  

  Keyamo Oghenerukevwe Anthonia•20

  @Anthonia03Posted 8 months ago

  @Iamtrieves

  Hey, maybe I can help. Did you upload it to GitHub? And if you followed the solution guide, it will tell you how to make it live. You go to settings in the repository you made of this solution and by your left, pages, under the build and deployment, make sure it says "Deploy from a branch" and under branch choose "master" which should be the only one there and click save beside it. Then wait, go to code and go back to pages, you will see a section that says "Your site is live at....", that will be your live URL and for your repository URL , in the main part of your repository, click code and copy the https URL there... that's the repository URL.

  I hope this was helpful

  0

  

  Iamtrieves•210

  @IamtrievesPosted 8 months ago

  @Anthonia03 dont worry about it, i was able to upload it and yes it is on GitHub. Thank you!

  1