HTML, CSS and JS

Community feedback

• 

  Thiago Santos•295

  @thiago-hdsPosted about 3 years ago

  Hi erelita! Great solution! It looks really close to the design.

  About the Javascript: it's not a good idea to add click handlers every time you hit the breakpoint. That way you might end up adding multiple handlers to the button that do the same thing and it's bad for performance.

  You could remove the previous handler before adding a new one but I think a better solution is to use JavaScript only to toggle the class that controls the visibility of the tooltip when the button is clicked. Let the CSS/media queries control how it should look. That way you also don't need to repeat it on the HTML markup.

  Hope this is helpful! 🙂

  Marked as helpful

  1

  ---

  

  Erel Ropeta•385

  @ereljapcoPosted about 3 years ago

  @thiago-hds Thank you so much for your feedback! :)

  I removed the matchMedia() and did what you recommended. I realized that I have used the same code for the tooltip-mobile and tooltip-desktop. LOL.

  It was a lot easier and responsive now thanks to you.

  Cheers! :)

  1