HTML, CSS, and JS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey Matthew, nice work on this challenge! Sorry that it's taken me a little while to take a look at it. You've done a really good job 👍

  Here are a few pointers after taking a look at your code:

  • You're switching naming conventions for your CSS classes. For example, you've got .nav-right-side and also .hashNewURL. Is there a reason for this? I'd recommend sticking to "Kebab Case" with all letters lowercase and hyphens separating the words for CSS.
  • I recommend avoiding IDs for styling purposes. They're too specific and can't be reused on the page. Instead, stick to class, attribute, pseudo, and type selectors. It will keep your CSS much easier to manage, especially on larger projects.
  • You're currently using max-width media queries. I'd recommend trying to use only min-width queries in a future project. You typically end up with less CSS code and it has the benefit of loading in fewer styles for mobile users.

  Let me know if you have any questions!

  1

  ---

  

  Matthew•190

  @MasterBirdyPosted almost 5 years ago

  Thanks for the feedback! These are all good points that I'll use in the next project.

  0