HTML, CSS and JS

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Hiya,

  This seems pretty good! Responsiveness is fine, too. There a few bits you could improve:

  1. You could give some margin-padding to your container, so the content doesn't touch the sides in mobile view (at 375px it's already touching sides).

  2. I believe the text "soon" shouldn't really have a different font-size as the rest of the title, it looks pretty odd.

  3. Your social icons should be wrapped in a <ul> instead of a <div>. They should also be <a> tags, as they're clickable links. Adding some transition to them would make the hover state look a lot nicer too!

  4. For the heading you should use a... heading element, not a paragraph. >.< An <h1> perhaps.

  5. You should look up relative units. Setting everything in pixels - apart from a few small things like borders, box-shadows - isn't really good practice.

  6. Your javascript: there's a typo in your alert message. Also, if this is your first attempt at javascript then it's okay, if not, I'd really really recommend not using var. We have let and const, use those. Also... if you used document.querySelector(".input"), you wouldn't get an array as a result but a single element. It's a small thing, but it would make your code more readable.

  Marked as helpful

  1
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted over 2 years ago

  Your solution looks great on both desktop and mobile. I also like your form validation which throws an alert.

  To help with your accessibility issue, use an h1 on your heading.

  Besides good job there👍 Happy coding💻👍

  Marked as helpful

  1