html, css and js

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 5 years ago

  Great work on this challenge Noha! 👍

  Here are a couple of pointers after taking a look at your code:

  • Whenever you add an img tag in the HTML always make sure you add an alt attribute to it with a description of the image. This is used by screen readers to make img tags accessible. Otherwise the screen reader will just read out the file path to the user.
  • I would always recommend never using IDs for styling purposes. This is because IDs are too specific when styling elements and they also can't be reused on a page.
  • Keep your media queries at the bottom of your CSS file, instead of the top. This makes sure that your styles inside the media query will overwrite styles written above by making use of the cascade and out-specifying earlier declarations.

  I hope these tips help! Let me know if you have any questions 🙂

  0