Html, CSS and JavaScript

Community feedback

• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Hello! It's a job well done~ The responsiveness looks good too.

  I have a few suggestions:

  1. Have a label tag or aria-label attribute for each input elements so that, the users know what they are for via screen reader.

  2. I think you might need an alt for your splitter logo. At least, users using screen reader will know what's the app's name.

  3. Regarding your question, I think you could add an event listener to the percentage button then, add a class to your reset button when the percentage button is clicked. Prior to the class being added, set the pointer-events:none to reset button so that it can't be clicked. After adding the class, unset the pointer-events and make it looks clickable via CSS e.g. changing the background-color.

  4. Add/remove classes instead of directly setting CSS properties in JS so that the code looks more organized. For e.g. adding .error class to show error-related styling, etc.

  Marked as helpful

  0
• 

  Elizabeth Okuta•150

  @MimieveshofuoPosted over 3 years ago

  Thanks for the feedback.

  0

  ---

  

  Amon•2,560

  @A-amonPosted over 3 years ago

  @Mimieveshofuo Glad to help!

  P.s. There's a Reply button/link on the top right of the comment.

  0