Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- DO NOT FORGET ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
- The logo should be outside ⚠️ the
nav
and itsalt tag
should not be blank, since it is not decorative. It should state they company’s name.
- The nav togggle button should be wrapping inside a
button
to be accessible and have aaria-label
,aria-expanded
andaria-control
.
- This LINK have a
role="list"
attribute.
- Numbers are never ❌ headings.
- This LINK should be an
article
⚠️ element.
-
The "The Bright Future of Web 3.0?" Is **not an **
h1
heading ❌, it is another article heading. It should be anh2
heading ✅ and there should be a visibly hiddenh1
in the site. -
Remove the
br
element you added, they are unnecessary ⚠️.
These are just of few improvements needed, there are still more…
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord